fix(blackfire): update to the latest version and URLs #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-code-scalingo[bot]](https://avatars.githubusercontent.com/u/4868969?s=60&v=4){kind=small}
EtienneM
force-pushed
the
feat/STORY-2477/scalingo-24_blackfire
branch
3 times, most recently
from
48055a8 to
9dbb8c6
Compare
EtienneM
force-pushed
the
feat/STORY-2477/scalingo-24_blackfire
branch
from
9dbb8c6 to
9ffb1c4
Compare
EtienneM
commented
Sep 1, 2025
There was a problem hiding this comment.
This file changes are just fixing linter offenses
There was a problem hiding this comment.
This file changes are just fixing linter offenses
| mv blackfire.so "${EXT_DIR}/blackfire.so" | ||
|
|
||
| tar -zxf agent.tar.gz | ||
| chmod +x agent |
There was a problem hiding this comment.
The binary name changed from agent to blackfire
EtienneM
requested review from
a team and
sc-david-voisin
and removed request for
a team
sc-david-voisin
approved these changes
Sep 1, 2025
| # https://docs.blackfire.io/up-and-running/installation?action=install&mode=full&location=local&os=manual&language=php&version=latest&#install-the-packages | ||
| # | ||
| # → Under "Install the Packages", select "Linux Binary" and 64 bits. Open the network inspector to identify the request triggered when you click on "Download". It contains the last version. | ||
| blackfire_agent_version=2.29.0 |
There was a problem hiding this comment.
praise: thanks for the clear explanation, well done for finding it !
|
|
||
| mkdir -p ${PREFIX}/etc/php/conf.d | ||
| cat > ${PREFIX}/etc/conf.d/blackfire.ini <<'EOF' | ||
| mkdir -p "${PREFIX}/etc/php/conf.d" |
There was a problem hiding this comment.
Suggested change
| mkdir -p "${PREFIX}/etc/php/conf.d" | |
| mkdir --parents "${PREFIX}/etc/php/conf.d" |
| mkdir -p package/ext/${zend_api_version} | ||
| pushd $tempbuilddir > /dev/null | ||
| tar zcvf $tempdir/package/ext/${zend_api_version}/php-${package_name}.tgz . | ||
| mkdir -p "package/ext/${zend_api_version}" |
There was a problem hiding this comment.
Suggested change
| mkdir -p "package/ext/${zend_api_version}" | |
| mkdir --parents "package/ext/${zend_api_version}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I successfully packaged the
blackfireextension for PHP 8.3 and 8.4 on the scalingo-24 stack.I also packaged the new version for scalingo-22.